Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for datetime deprecation and standardizing timezone and isoformat (Issue #2327) #2329

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

imperorrp
Copy link
Contributor

@imperorrp imperorrp commented Mar 22, 2024

Fix for datetime deprecation issue and standardizing timezone(UTC) and format(isoformat) for datetime updates on concatenating InferenceData (issue #2327 )

Description

The "created_at" default attribute in the make_attrs function in arviz/data/base.py is updated to avoid deprecation as well as work for Python 3.10, which is still supported by ArviZ.

The current_time variable in the concat function in arviz/data/inference-data.py is also updated to use the UTC timezone and is isoformatted.

Checklist

  • Follows official PR format
  • Includes a sample plot to visually illustrate the changes (only for plot-related functions)
  • New features are properly documented (with an example if appropriate)?
  • Includes new or updated tests to cover the new feature
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

📚 Documentation preview 📚: https://arviz--2329.org.readthedocs.build/en/2329/

…d format(isoformat) for datetime updates on concatenating InferenceData
Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing test is unrelated, due to a deprecation in scipy.signal. Next release will remove gaussian function from there so we should fix that soonish too. We can merge this already though

@OriolAbril OriolAbril merged commit 7c52d0a into arviz-devs:main Mar 25, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants