Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed plot_trace legend overwriting by chain legend (Issue #2320) #2334

Merged
merged 9 commits into from
Apr 8, 2024
Merged

Fixed plot_trace legend overwriting by chain legend (Issue #2320) #2334

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a205b88
Fixed plot_trace legend overwriting
imperorrp Mar 26, 2024
c0bb227
Merge branch 'arviz-devs:main' into traceplot_legend_fix
imperorrp Mar 31, 2024
8920d35
Modified base_tests/trace_plot_matplotlib for legend fix
imperorrp Mar 31, 2024
03201bf
Merge branch 'traceplot_legend_fix' of https://github.com/imperorrp/a…
imperorrp Mar 31, 2024
d60b68c
formatted with black
imperorrp Apr 4, 2024
3df7aa6
Merge branch 'arviz-devs:main' into traceplot_legend_fix
imperorrp Apr 4, 2024
21d8391
Merge branch 'arviz-devs:main' into traceplot_legend_fix
imperorrp Apr 7, 2024
c7c1e73
Update CHANGELOG.md
imperorrp Apr 7, 2024
83746ba
shorten changelog entry
OriolAbril Apr 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions arviz/plots/backends/matplotlib/traceplot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,8 +440,8 @@ def plot_trace(
[], [], label="combined", **dealiase_sel_kwargs(plot_kwargs, chain_prop, -1)
),
)
ax.figure.axes[0].legend(handles=handles, title="chain", loc="upper right")

ax.figure.axes[1].legend(handles=handles, title="chain", loc="upper right")
if axes is None:
axes = np.array(ax.figure.axes).reshape(-1, 2)

Expand Down
2 changes: 1 addition & 1 deletion arviz/tests/base_tests/test_plots_matplotlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ def test_plot_trace_legend(compact, combined):
axes = plot_trace(
idata, var_names=["home", "atts_star"], compact=compact, combined=combined, legend=True
)
assert axes[0, 0].get_legend()
assert axes[0, 1].get_legend()
compact_legend = axes[1, 0].get_legend()
if compact:
assert axes.shape == (2, 2)
Expand Down
Loading