Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use second optional positional attribute (target) as generated-file-name #69

Merged
merged 2 commits into from
May 12, 2020
Merged

Use second optional positional attribute (target) as generated-file-name #69

merged 2 commits into from
May 12, 2020

Conversation

anb0s
Copy link
Contributor

@anb0s anb0s commented May 10, 2020

Closes #48

anb0s added 2 commits May 10, 2020 21:53
@anb0s
Use second optional positional attribute (target) as generated-file-name
00a8a69 
Closes asciidoctor#48
@anb0s
increase timeout for 'should inline an SVG image with kroki-fetch-dia…
06d641f 
…gram'

Conversion
   When extension is registered
       should inline an SVG image with kroki-fetch-diagram:
   Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (C:\Users\kenobi\dev\asciidoctor-kroki\test\test.js)
      at processImmediate (internal/timers.js:456:21)
@anb0s
Copy link
Contributor Author

anb0s commented May 10, 2020

@Mogztter i've adapted and copied two tests where the second positional attribute was used to have tests with empty and given diagram-name.

@danyill danyill mentioned this pull request May 12, 2020
Merged
@ggrossetie
Copy link
Member

Thanks for your contribution. Greatly appreciated 👍

ggrossetie
ggrossetie approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@ggrossetie ggrossetie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ggrossetie ggrossetie merged commit beaf140 into asciidoctor:master May 12, 2020
@anb0s anb0s deleted the diagram-name branch May 12, 2020 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggrossetie ggrossetie ggrossetie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[kroki-fetch-diagram] generated-file-name parameter not used
2 participants
@anb0s @ggrossetie