Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prefix messages with 'asdf: ' #1479

Closed
wants to merge 2 commits into from

Conversation

hyperupcall
Copy link
Contributor

@hyperupcall hyperupcall commented Feb 18, 2023

Summary

Sometimes asdf prints messages, and it's not obvious that the message is coming from asdf. This fixes that.

It does so by prepending asdf: to every single user-read console message, but only on the asdf exec subcommand codepath.

Fixes: #1467

@hyperupcall hyperupcall marked this pull request as ready for review February 19, 2023 06:49
@hyperupcall hyperupcall requested a review from a team as a code owner February 19, 2023 06:49
@jthegedus
Copy link
Contributor

I am not sure this is the right solution to this problem. The initial report has a few things going on:

  1. .tool-versions wasn't interpolated
  2. the user found the error output format confusing
  3. the user did not know which tool produced this error

I don't think prefixing all outputs with asdf: is the best solution here.

I do like the OPs suggestion for including

asdf did not find a version...

That is clear which tool produced the error.

And so perhaps this PR can be used to make that change.

That solves 3.

Solving 1 will take more investigation.

Solving 2 I think is related to #928 more than anything.

@hyperupcall
Copy link
Contributor Author

Yeah you're right, that's a lot better - I'm not sure what I was thinking...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No version manager name reported in CLI output, consider adding it
2 participants