Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up terraform files #159

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Split up terraform files #159

merged 2 commits into from
Oct 9, 2023

Conversation

reweeden
Copy link
Contributor

This continues some work that we did in CIRRUS-DAAC to split up the terraform files a bit more to make it easier to jump to specific parts.

Copy link
Contributor

@mattp0 mattp0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the changes to tf: cumulus-prefix to prefix, might want to include a change log entry as this does a little more than split up the resources into files in case someone is using that value somehow.

@reweeden
Copy link
Contributor Author

How would anyone be using it? I don't think there's any way for the locals defined in CORE to bleed over into DAAC.

@reweeden
Copy link
Contributor Author

Which is to say, I'm pretty sure the local names here are just internal implementation details and can be safely changed without affecting the 'public API' so to speak.

@reweeden reweeden force-pushed the rew/refactor-terraform-files branch from 2187c26 to bd9f1ac Compare October 9, 2023 15:10
@reweeden reweeden requested a review from mattp0 October 9, 2023 15:15
@reweeden reweeden merged commit 2c1f63b into master Oct 9, 2023
2 checks passed
@reweeden reweeden deleted the rew/refactor-terraform-files branch October 9, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants