Add deploy_cumulus_distribution variable to cumulus module
#166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@reweeden sorry it's taken me so long to look at this. In general I have no problem exposing Cumulus variables via CIRRUS, but I think the CIRRUS default should match the Cumulus default. It looks to me like the Cumulus default is false: https://github.com/nasa/cumulus/blob/master/tf-modules/cumulus/variables.tf#L608-L612 Is there a reason you think it should be true by default? |
|
That's a good point! It probably does make sense to keep it consistent with the cumulus defaults in CIRRUS-core. |
lindsleycj
reviewed
Oct 7, 2023
reweeden
force-pushed
the
rew/add-teacache-switch-v17
branch
from
1ec1508
to
a7e3f30
Compare
reweeden
force-pushed
the
rew/add-teacache-switch-v17
branch
from
a7e3f30
to
2fc533f
Compare
lindsleycj
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #165 but for the main branch.
Does the way I did the changelog entries make sense?