PR-6094 Add Docker-in-Docker support #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the docker file needs to have the docker binary installed then |
|
Yea, in order to rewrite our build process to call docker from the Makefile we'll need to do that. The terraform provider doesn't need it installed however, and that's currently all we're using this for so maybe not strictly necessary for this PR? Mostly this was just to ensure that you can continue to run the deployment locally. |
|
Should also add a note in the readme about docker-in-docker and how to run it correctly. |
reweeden
force-pushed
the
rew/docker-in-docker
branch
from
1eb5308
to
4fa7866
Compare
mckadesorensen
approved these changes
Aug 9, 2024
reweeden
force-pushed
the
rew/docker-in-docker
branch
from
4fa7866
to
c6d78d7
Compare
reweeden
changed the title
mattp0
approved these changes
Sep 11, 2024
mckadesorensen
approved these changes
Sep 11, 2024
lindsleycj
approved these changes
Sep 11, 2024
gjclark
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method taken from here: https://devopscube.com/run-docker-in-docker/
This method works well for pulling/pushing images but things get weird when you need to interact with the host filesystem such as when mounting a docker volume. The files mounted to the inner container will come directly from the host system and not from within the CIRRUS-core container. This makes writing the correct paths in the makefile a lot more tricky, since volume mounts want an absolute path and the absolute path on the host vs inside the container will not be the same.
We need this for ASF to be able to deploy some of our workflows that build and push container images to ECR for our step function activity tasks. Our CI has it set up already because it builds and runs the container image using a different command, but for local development we would want this capability in the CIRRUS-core makefile.