Python 3.9 Support #202
Merged
Python 3.9 Support #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has been tested on the NISAR upgrade and the ASF upgrade and the dependency issues are resolved. |
mattp0
commented
Aug 8, 2024
| # Uncommenting fixes: `fatal: detected dubious ownership in repository at '/CIRRUS-core' | ||
| # Uncommenting fixes: `fatal: detected dubious ownership in repository at '/CIRRUS-DAAC' | ||
| # COPY .gitconfig /.gitconfig | ||
| RUN python3 -m pip install boto3 setuptools |
There was a problem hiding this comment.
this is probably not needed as IIRC boto3 comes on the amazon images
gjclark
reviewed
Aug 8, 2024
gjclark
reviewed
Aug 8, 2024
mattp0
force-pushed
the
mrp/feature/18.3.1.1
branch
2 times, most recently
from
24445e5
to
af41998
Compare
mattp0
force-pushed
the
mrp/feature/18.3.1.1
branch
from
74fc133
to
4ce69d2
Compare
gjclark
approved these changes
Aug 8, 2024
mckadesorensen
approved these changes
Aug 8, 2024
|
big question here is, does moving back to node 16.x in the build image effect any of the users ? otherwise the experience will be the same. python 3.9 on an amazon linux 2 container. https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html |
reweeden
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the AWS Lambda image for python 3.9
Node is set to 16.x because node 18.x and 20.x require glibc>=2.28 and 2.27 is present on amazon linux 2
Rather than try and install node 18.x or 20.x on amazon linux 2 we can keep what we had as the primary use I have seen is to deploy the cumulus dashboard.
This is a resolution to a dependency layer issue ASF encounter while building on amazon linux 2023.
Ideally once CMA can be built on python 3.12 we can update to the amazon linxu 2023 and use python 3.12 and node 20.x