examples: Import align_of() from mem to build on on MSRV < 1.80
#955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #931 we worked around "unnecessary import" warnings for the `size_of(_val)()` functions being added to the prelude in Rust 1.80 while maintaining some form of MSRV back-compatibility (despite not testing the examples against this), but forgot about `align_of()`. This means the examples still build on Rust 1.80 or higher because `align_of()` is always in scope via the prelude there, but not on older compilers. Fix this by adding it to the import that's tagged to be removed when we bump all of `ash` to MSRV 1.80.
Ralith
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #954
In #931 we worked around "unnecessary import" warnings for the
size_of(_val)()functions being added to the prelude in Rust 1.80 while maintaining some form of MSRV back-compatibility (despite not testing the examples against this), but forgot aboutalign_of(). This means the examples still build on Rust 1.80 or higher becausealign_of()is always in scope via the prelude there, but not on older compilers. Fix this by adding it to the import that's tagged to be removed when we bump all ofashto MSRV 1.80.