Allow swapping the HTTP stack. #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
force-pushed
the
swap-http
branch
4 times, most recently
from
0714e0d
to
93d58a0
Compare
ashkan18
approved these changes
Oct 26, 2017
| @@ -307,6 +317,26 @@ describe App do | |||
| end | |||
| ``` | |||
|
|
|||
| Alternately you can `stub_request` with Webmock. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7.
This allows you to swap the HTTP adapter at runtime and implements one for
Net::HTTP.However this doesn't remove Faraday as a required dependency. I opened #30, I think I want to leave that unimplemented but open in case someone feels strongly about it.