Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heroku Release Phase bug #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Heroku Release Phase bug #10

wants to merge 1 commit into from

Conversation

sol
Copy link

@sol sol commented Oct 28, 2019

release phase task defined in Procfile are run before the app is
made available. If a task fails, the new release is not deployed.

However, the GitHub deploy status is set to "success" before any
releases task are run. This has two consequences:

  1. The GitHub deploy status does not accurately reflect the outcome of
    the release.
  2. Assertible will run before the app is deployed. So Assertible will
    either use a stale release, or fail if there was no previous release.

https://devcenter.heroku.com/articles/release-phase

`release` phase task defined in `Procfile` are run before the app is
made available.  If a task fails, the new release is not deployed.

However, the GitHub deploy status is set to "success" before any
releases task are run.  This has two consequences:

1. The GitHub deploy status does not accurately reflect the outcome of
   the release.
2. Assertible will run before the app is deployed.  So Assertible will
   either use a stale release, or fail if there was no previous release.

https://devcenter.heroku.com/articles/release-phase
@creichert creichert temporarily deployed to go-heroku-assertible-exa-pr-10 October 28, 2019 16:40 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants