Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always load index column with no pandas metadata #449

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

smcguire-cmu
Copy link
Contributor

@smcguire-cmu smcguire-cmu commented Oct 21, 2024

Previously, if there was pandas metadata the index column would be always loaded and set as the DataFrame index, even if the users specified columns that didn't include it. With no pandas metadata, the index column would be ignored and the default pandas index used in the DataFrame.

This updates catalog loading to always load the index column if available, with or without pandas metadata.

Fixes #446

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

Before [aa1780a] <v0.4.0> After [1c7f041] Ratio Benchmark (Parameter)
failed failed n/a benchmarks.time_box_filter_on_partition
failed failed n/a benchmarks.time_create_large_catalog
failed failed n/a benchmarks.time_create_midsize_catalog
29.7±0.8ms 30.3±0.8ms 1.02 benchmarks.time_polygon_search
97.8±3ms 97.4±0.7ms 1.00 benchmarks.time_kdtree_crossmatch

Click here to view all benchmarks.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.75%. Comparing base (aa1780a) to head (a176b91).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #449      +/-   ##
==========================================
+ Coverage   97.62%   97.75%   +0.13%     
==========================================
  Files          44       44              
  Lines        1558     1562       +4     
==========================================
+ Hits         1521     1527       +6     
+ Misses         37       35       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tests/conftest.py Show resolved Hide resolved
@smcguire-cmu smcguire-cmu merged commit 1a2ba00 into main Oct 22, 2024
10 of 12 checks passed
@smcguire-cmu smcguire-cmu deleted the sean/fix-columns-index branch October 22, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Without pandas metadata, index column isn't loaded when user specifies columns to read_hats
2 participants