Skip to content
This repository has been archived by the owner on Aug 11, 2023. It is now read-only.

Check whether setup_requires really needs to be defined #209

Closed
astrofrog opened this issue Nov 26, 2016 · 2 comments
Closed

Check whether setup_requires really needs to be defined #209

astrofrog opened this issue Nov 26, 2016 · 2 comments

Comments

@astrofrog
Copy link
Member

astrofrog commented Nov 26, 2016

If so, setup_requires should include Cython if the package includes Cython code and the current version is a developer version. See #131 for a discussion of this.

A better solution might be to simply populate setup_requires in setup.py based on which extensions are being passed to setup.py. I'll work on a PR for that to see if it works. Or we can just check whether Cython files are present.

@astrofrog astrofrog changed the title Make sure setup_requires is defined Check whether setup_requires really needs to be defined Nov 26, 2016
@cmccully
Copy link

Also, numpy often has to be installed before setup if you are using Cython as it often has to tell the c compiler where to find the numpy include files.

@pllim
Copy link
Member

pllim commented Jan 31, 2020

Irrelevant due to #438

@pllim pllim closed this as completed Jan 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants