-
-
Notifications
You must be signed in to change notification settings - Fork 63
Use pytest-astropy-header for test header #436
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,7 @@ url = {{ cookiecutter.project_url }} | |
edit_on_github = {{ cookiecutter.edit_on_github_extension }} | ||
github_project = {{ cookiecutter.github_project }} | ||
python_requires = ">={{ cookiecutter.minimum_python_version }}" | ||
tests_require = pytest; pytest-astropy; pytest-astropy-header | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should pytest-astropy be a strict dependency? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It will be with this patch because I removed the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yeah, but I think using pytest-astropy-header should just work for everything, isn't it (at least that was the reason I was pushing for having it as a separate plugin rather than shuffled into pytest-astropy) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Correct. Theoretically it would work even if you have older astropy version, but that also makes it a compulsory dependency for tests. Or did I misunderstand your question? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no I think we're on the same page. But then we don't need to list pytest-astropy here, right? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh yeah... |
||
|
||
[options] | ||
# install_requires should be formatted as a semicolon-separated list, e.g.: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pytest-astropy should contain pytest-astropy-header
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it back in. For some reason, removing it caused Travis to fail for all but the last job. 🤷♀️