Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: external link will open in the same window #1060

Merged
merged 9 commits into from
Oct 16, 2024

Conversation

ItshMoh
Copy link
Contributor

@ItshMoh ItshMoh commented Oct 2, 2024

Now the external link will open in the same window.

Description

Related issue(s)
#962
video

Copy link

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 🚀

@AceTheCreator AceTheCreator self-requested a review as a code owner October 7, 2024 17:42
Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ItshMoh, i don't think external link should open in the same window, instead we should let users know it opens a new window as indicated in the issue :)

@ItshMoh
Copy link
Contributor Author

ItshMoh commented Oct 8, 2024

@ItshMoh, i don't think external link should open in the same window, instead we should let users know it opens a new window as indicated in the issue :)

Hey @AceTheCreator Do you want the message for opening to the new window like this.
alert_new_window_react
Here when user clicks the link it will get alert notifcations.

@AceTheCreator
Copy link
Member

@ItshMoh, i don't think external link should open in the same window, instead we should let users know it opens a new window as indicated in the issue :)

Hey @AceTheCreator Do you want the message for opening to the new window like this. alert_new_window_react Here when user clicks the link it will get alert notifcations.

@ItshMoh, it doesn't have to be an alert, you can just add the warning message inside the title attribute like this:

Visit Example Site

The warning will appear as tooltip when link is hovered over.

@ItshMoh
Copy link
Contributor Author

ItshMoh commented Oct 15, 2024

@ItshMoh, i don't think external link should open in the same window, instead we should let users know it opens a new window as indicated in the issue :)

Hey @AceTheCreator Do you want the message for opening to the new window like this. alert_new_window_react Here when user clicks the link it will get alert notifcations.

@ItshMoh, it doesn't have to be an alert, you can just add the warning message inside the title attribute like this:

Visit Example Site

The warning will appear as tooltip when link is hovered over.

Hey @AceTheCreator i have added the tooltip on hovering over the button.
react_open_new_window

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@AceTheCreator
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 5fc29df into asyncapi:master Oct 16, 2024
10 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.3.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants