fix: #907 sidebar broken in playground #1066
Conversation
surajTade
requested review from
magicmatatjahu,
derberg,
fmvilas and
asyncapi-bot-eve
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
@surajTade can you share a video of your fix? |
Screen.Recording.2024-10-05.224812.mp4 |
There was a problem hiding this comment.
@surajTade i don't think you're doing the correct thing here 👀
I tired that fix on different screen sizes and it seems to be working fine, can you please elaborate on what could be wrong in this? |
|
This is what i get when i test your implementation here: |
I see, I'm not sure why I'm not facing this issue: Screen.Recording.2024-10-06.100045.mp4 |
|
@surajTade here's a draft PR that fixes this https://github.com/asyncapi/asyncapi-react/pull/1072/files. You can copy the fix from there :) |
|
|
That's strange. Can i see your implementation? maybe update this PR with suggested changes |
…de/asyncapi-react into issue-907-sidebar-broken
…de/asyncapi-react into issue-907-sidebar-broken
|
@surajTade, removed the changes you made to the layout file. Kindly test it :) |
|
@surajTade any update? |
|
|
/rtm |
|
🎉 This PR is included in version 2.4.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Changes proposed in this pull request:
Related issue(s)
Fixes #907, #908