Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add message size/length to mqtt and mqtt5 #198

Closed
tomkralidis opened this issue May 24, 2023 · 6 comments · Fixed by #201
Closed

add message size/length to mqtt and mqtt5 #198

tomkralidis opened this issue May 24, 2023 · 6 comments · Fixed by #201
Labels
enhancement New feature or request

Comments

@tomkralidis
Copy link

Reason/Context

It would be valuable to add message size/length (in bytes) to the MQTT bindings to advertise the maximum message size a given MQTT binding accepts/emits.

Description

Given this is a feature/enhancement, it is not a breaking change. Example definition:

MQTT5:

    bindings:
      mqtt5:
        messageMaxSize: 4096

MQTT:

    bindings:
      mqtt:
        messageMaxSize: 4096

Happy to put forth a PR if the above seems reasonable.

@tomkralidis tomkralidis added the enhancement New feature or request label May 24, 2023
@github-actions
Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@pearmaster
Copy link
Contributor

In MQTTv5, there is the "Maximum Packet Size" property on the CONNECT message. See https://docs.oasis-open.org/mqtt/mqtt/v5.0/os/mqtt-v5.0-os.html#_Toc3901050

So I would propose the MQTTv5 bindings follow the same terminology:

bindings:
  mqtt5:
    maximumPacketSize: 4096

I'm hoping to put together a PR for MQTTv5 bindings that includes this and several other MQTTv5 properties (including user properties). I probably will not touch the mqtt (v3) bindings.

@pearmaster
Copy link
Contributor

pearmaster commented May 25, 2023

I've submitted an enhancement ticket for MQTTv5 properties, which would solve the v5 half of this issue: #199

@tomkralidis
Copy link
Author

+1. Looking forward to this addition!

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Sep 23, 2023
@tomkralidis
Copy link
Author

Update: looks like this is being covered in #201.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants