-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add message size/length to mqtt and mqtt5 #198
Comments
Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request. |
In MQTTv5, there is the "Maximum Packet Size" property on the CONNECT message. See https://docs.oasis-open.org/mqtt/mqtt/v5.0/os/mqtt-v5.0-os.html#_Toc3901050 So I would propose the MQTTv5 bindings follow the same terminology: bindings:
mqtt5:
maximumPacketSize: 4096 I'm hoping to put together a PR for MQTTv5 bindings that includes this and several other MQTTv5 properties (including user properties). I probably will not touch the |
I've submitted an enhancement ticket for MQTTv5 properties, which would solve the v5 half of this issue: #199 |
+1. Looking forward to this addition! |
This issue has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation. There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
Update: looks like this is being covered in #201. |
Reason/Context
It would be valuable to add message size/length (in bytes) to the MQTT bindings to advertise the maximum message size a given MQTT binding accepts/emits.
Description
Given this is a feature/enhancement, it is not a breaking change. Example definition:
MQTT5:
MQTT:
Happy to put forth a PR if the above seems reasonable.
The text was updated successfully, but these errors were encountered: