-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MQTT5 CONNECT and PUBLISH Properties #199
Comments
Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request. |
Relation to #198 |
@fmvilas While I'm looking at this, I see that servers:
prod:
bindings:
mqtt:
clientId: guest
mqtt5:
sessionExpiryInterval: 60 or should the relevant |
I think we somehow defined |
I'll adapt my MR to merge both binding definitions (plus the new stuff) into |
Awesome, thanks! 🙏 |
This issue has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation. There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
Reason/Context
One of the defining features of MQTTv5 are Properties. (otherwise, you'd probably just use MQTT v3). Properties can be included in almost all MQTT packet types, and can form a significant part of an MQTTv5 API contract.
In issue asyncapi/spec#878 @fmvilas suggested that
bindings
are the appropriate construct for describing properties.For more information, this page lists properties by packet type: http://www.steves-internet-guide.com/mqttv5-properties/
Description
I suggest adding additional fields to the MQTT5 server binding for MQTT CONNECT packets:
I suggest adding additional fields to the MQTT5 message bindings for MQTT PUBLISH packets:
User Property(These are OK to be message headers per How to describe MQTT v5 user properties in an AsyncAPI document? spec#878 (comment))I have a pull request that is about ready to go once this issue is approved (according to the contributing guidelines)
Side note: I've used the word "packet" above when the correct MQTT terminology is "message" to disambiguate from AsyncAPI "message" objects.
The text was updated successfully, but these errors were encountered: