Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable additionalProperties for kafka topicConfigurationObject #231

Closed
gokerakc opened this issue Dec 12, 2023 · 3 comments
Closed

Enable additionalProperties for kafka topicConfigurationObject #231

gokerakc opened this issue Dec 12, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@gokerakc
Copy link
Contributor

gokerakc commented Dec 12, 2023

Reason/Context

Currently, only 5 topic configuration properties are supported by the asyncapi kafka binding (json schema here).

These properties are;

  • cleanup.policy
  • retention.ms
  • retention.bytes
  • delete.retention.ms
  • max.message.bytes

But in some cases, there is a need to specify vendor-specific topic configurations (e.g. confluent-topic-configs). For that reason I think it makes sense to increase the version of that binding and enable additionalProperties for the topicConfigurationObject.

In my use case, I need to use the following additional properties and they can also be added to the topicConfigurationObject if you see a good fit. Please see the properties from the vendor and proposed property names for the topicConfigurationObject:

  • confluent.key.schema.validation (schema.key.validation.enabled)
  • confluent.key.subject.name.strategy (schema.key.lookup.strategy)
  • confluent.value.schema.validation (schema.value.validation.enabled)
  • confluent.value.subject.name.strategy (schema.value.lookup.strategy)

Please share your thoughts about enabling additional properties and adding these optional properties to the object.

@gokerakc gokerakc added the enhancement New feature or request label Dec 12, 2023
Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@gokerakc
Copy link
Contributor Author

@lbroudoux I would like to get your thoughts on this because you commented about adding new properties before.

@derberg
Copy link
Member

derberg commented Feb 29, 2024

looks like completed

@derberg derberg closed this as completed Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants