feat: add new kafka topic configuration properties #481
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
Very much needed! 👍 We're struggling to work around these gaps with |
|
Hey, please just remember that JSON Schema is just a tool, not a spec itself so whatever is added to JSON Schema, first need to be added to Kafka Binding spec -> https://github.com/asyncapi/bindings/tree/master/kafka |
|
I've updated this PR as a draft because the following PR needs to be reviewed first: |
gokerakc
force-pushed
the
update_kafkaTopicConfigurationObject
branch
2 times, most recently
from
b643e30
to
abe48ab
Compare
|
Given the related bindings PR (asyncapi/bindings#238) got merged I think we can continue with this one. I've added a new schema version (0.5.0) to reflect the new changes in the kafka topic configuration object. It would be great if you could re-review this PR @dalelane. |
gokerakc
force-pushed
the
update_kafkaTopicConfigurationObject
branch
from
4e5e0d0
to
ef3aa1f
Compare
gokerakc
requested review from
CameronRushton,
fmvilas,
derberg,
smoya,
char0n,
asyncapi-bot-eve and
GreenRover
as code owners
|
gokerakc
force-pushed
the
update_kafkaTopicConfigurationObject
branch
from
ef3aa1f
to
f1403e0
Compare
|
Sorry guys, I've messed around with my commits. I had a problem verifying my signature but now it's fixed. It seems like extra checks (Test NodeJS PR ones) were added because of my commit changes. If it's necessary, I can close this PR and create a new one. Can you please re-approve the PR? @dalelane |
|
|
/rtm |
derberg
changed the title
|
/rtm |
|
🎉 This PR is included in version 6.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
There was a problem hiding this comment.
@gokerakc hey, I see we overlooked and did not make sure you add new version to proper definitions. Can you add 0.5.0 to:
- https://github.com/asyncapi/spec-json-schemas/blob/master/definitions/3.0.0/operationBindingsObject.json#L134
- https://github.com/asyncapi/spec-json-schemas/blob/master/definitions/3.0.0/serverBindingsObject.json#L53
- https://github.com/asyncapi/spec-json-schemas/blob/master/definitions/3.0.0/channelBindingsObject.json#L87
- https://github.com/asyncapi/spec-json-schemas/blob/master/definitions/3.0.0/messageBindingsObject.json#L134
and I do not only mean an enum, to add it to enum, but also respective if statement?
if you do it just ping me and I will review and merge with higher priority
as for now, new version is not really in place as anyway documents with 0.5.0 binding are not accepted as valid
cf. spotted in a comment in asyncapi#481 Signed-off-by: Dale Lane <[email protected]>
cf. spotted in a comment in asyncapi#481 Signed-off-by: Dale Lane <[email protected]>
|
Thanks @dalelane! |
Description
The following updates are introduced for the kafka topic configuration object:
Please check the related issue for more details.
Note: Once we are happy with the changes I'll create another PR to update the bindings' README file in the other repo.
Related issue(s)
Resolves the following issue: asyncapi/bindings#231