feat: adapt HTTP bindings to v3 #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonaslagoni
requested review from
derberg,
fmvilas,
dalelane,
smoya,
char0n and
asyncapi-bot-eve
as code owners
This was referenced Jun 13, 2023
jonaslagoni
changed the title
fmvilas
reviewed
Jun 26, 2023
smoya
reviewed
Jun 27, 2023
Co-authored-by: Sergio Moya <[email protected]>
derberg
reviewed
Jun 28, 2023
Co-authored-by: Lukasz Gornicki <[email protected]>
smoya
reviewed
Jun 28, 2023
derberg
approved these changes
Jul 25, 2023
|
@derberg yes 👍 |
|
/rtm |
fmvilas
reviewed
Aug 21, 2023
| [schemaObject]: https://www.asyncapi.com/docs/specifications/latest/#schemaObject |
There was a problem hiding this comment.
Just a thought. Would be cool to have a redirect on the website that would let us point to the latest minor version of a major. For instance, something like:
Suggested change
| [schemaObject]: https://www.asyncapi.com/docs/specifications/latest/#schemaObject | |
| [schemaObject]: https://www.asyncapi.com/docs/specifications/3/#schemaObject |
Which would redirect to https://www.asyncapi.com/docs/specifications/3.0.0/#schemaObject for now but would resolve to https://www.asyncapi.com/docs/specifications/3.4.0/#schemaObject in the future (when 3.4.0 is out).
There was a problem hiding this comment.
If this is not implemented yet, I would love to have this in place. For sure super useful when sharing links to the ref for a particular major version. Did you create an issue in website @fmvilas ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adapts the HTTP bindings to v3. This first round of review is just for the general structure changes.
TODO right before final review:
TODO after merge:
Related issue(s)
Related to #182