Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove git HEAD marks left in Kafka binding README.md #220

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

smoya
Copy link
Member

@smoya smoya commented Nov 7, 2023

Description

This PR fixes a wrong git merge that happened in kafka/README.md file in #143 (comment)

Related issue(s)
#143 (comment)

cc @char0n

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@smoya
Copy link
Member Author

smoya commented Nov 7, 2023

/rtm

@char0n
Copy link
Collaborator

char0n commented Nov 10, 2023

@lbroudoux @dalelane would you please look into this? It's a simple editorial change fixing remnants of the merge

@lbroudoux
Copy link
Collaborator

Thanks for the heads-up. We agreed with @dalelane in the previous #182 comment to fix this one when updating bindings for v3. Thus, the fix is integrated within #221

I think we can cancel this one as changes in #221 are larger.

@smoya
Copy link
Member Author

smoya commented Nov 24, 2023

@lbroudoux I believe we should merge this asap. #221 is still under discussion regarding branch strategy, etc.
This PR though is fixing current master, which is currently showing ambiguity in the Message binding
Google Chrome_iicWh2oL

cc @dalelane

@lbroudoux
Copy link
Collaborator

Going to review and merge it following the hold on discussions on #221 in #182 (comment).

Copy link
Collaborator

@lbroudoux lbroudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lbroudoux lbroudoux merged commit 36073fe into asyncapi:master Nov 24, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants