Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding support to change the collection type for arrays in Java models #1437

Closed

Conversation

borrull
Copy link

@borrull borrull commented May 20, 2024

Description
This PR adds support to change the collection type in Java models by introducing a new parameter "javaArrayType" to the generate models command.

Related issue(s)
Resolves #1436

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@borrull borrull changed the title feat: Adding support to change the collection type for arrays in Java models feat: adding support to change the collection type for arrays in Java models May 20, 2024
Copy link
Member

@peter-rr peter-rr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@borrull
Copy link
Author

borrull commented May 23, 2024

/u

@borrull
Copy link
Author

borrull commented May 28, 2024

/u

Copy link

sonarcloud bot commented May 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Amzani
Copy link
Collaborator

Amzani commented Jun 5, 2024

@borrull could you sync with @jonaslagoni as you might conflict with #1376
I'm closing this PR for now.

@Amzani Amzani closed this Jun 5, 2024
@jonaslagoni
Copy link
Member

@borrull, do you want me to add your code to https://github.com/asyncapi/modelina/tree/next/modelina-cli or do you want to help make the contribution there?

@borrull
Copy link
Author

borrull commented Jun 7, 2024

@jonaslagoni if it can wait for 2-3 hours, I can make the contribution there. Otherwise, please go ahead :-)

@jonaslagoni
Copy link
Member

All yours @borrull, need your help if you are up for it✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add support to change the collection type for arrays in Java models
5 participants