feat: adding support to change the collection type for arrays in Java models #2029
Conversation
borrull
requested review from
magicmatatjahu,
jonaslagoni,
kennethaasan and
asyncapi-bot-eve
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for modelina canceled.
|
|
|
Created this PR to implement the same as in asyncapi/cli#1437 to address asyncapi/cli#1436 , but being blocked by Sonar due to duplications on test file. Am I missing something here? |
| javaArrayType: Flags.string({ | ||
| type: 'option', | ||
| description: 'Java specific, define which type of array needs to be generated.', | ||
| options: ['Array', 'List'], |
There was a problem hiding this comment.
| options: ['Array', 'List'], | |
| options: ['array', 'list'], |
Lets keep it to all lower case or all upper case options for now ✌️
| description: 'Java specific, define which type of array needs to be generated.', | ||
| options: ['Array', 'List'], | ||
| required: false, | ||
| default: 'Array' |
There was a problem hiding this comment.
| default: 'Array' | |
| default: 'array' |
| const fileGenerator = new JavaFileGenerator({ presets }); | ||
| const fileGenerator = new JavaFileGenerator({ | ||
| presets, | ||
| collectionType: javaArrayType as 'Array' | 'List' |
There was a problem hiding this comment.
| collectionType: javaArrayType as 'Array' | 'List' | |
| collectionType: javaArrayType as 'array' | 'list' |
| test | ||
| .stderr() | ||
| .stdout() | ||
| .command([...generalOptions, 'java', ASYNCAPI_V2_DOCUMENT, `-o=${ path.resolve(outputDir, './java')}`, '--packageName', 'test.pkg', '--javaArrayType=List']) |
There was a problem hiding this comment.
| .command([...generalOptions, 'java', ASYNCAPI_V2_DOCUMENT, `-o=${ path.resolve(outputDir, './java')}`, '--packageName', 'test.pkg', '--javaArrayType=List']) | |
| .command([...generalOptions, 'java', ASYNCAPI_V2_DOCUMENT, `-o=${ path.resolve(outputDir, './java')}`, '--packageName', 'test.pkg', '--javaArrayType=list']) |
Just ignore it 🙂 |
|
🎉 This PR is included in version 4.0.0-next.49 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@all-contributors please add @borrull for code, test |
|
I've put up a pull request to add @borrull! 🎉 |
Description
This PR adds support to change the collection type in Java models by introducing a new parameter "javaArrayType" to the generate models command.
Checklist
npm run lint).npm run test).