Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ticket section render issue #445

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

toffee-k21
Copy link
Contributor

Description

Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for peaceful-ramanujan-288045 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 191ad02
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/67258772a777d100089091c2
😎 Deploy Preview https://deploy-preview-445--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@toffee-k21 we should stick to using the existing ticket cards. We should list all the tickets and only enable the upcoming conference ticket(which should come first)

@toffee-k21
Copy link
Contributor Author

@toffee-k21 we should stick to using the existing ticket cards. We should list all the tickets and only enable the upcoming conference ticket(which should come first)

Hey @AceTheCreator, I've updated the Ticket section to show upcoming events first, followed by events ended. This functionality was already implemented

@AceTheCreator
Copy link
Member

@toffee-k21 we should stick to using the existing ticket cards. We should list all the tickets and only enable the upcoming conference ticket(which should come first)

Hey @AceTheCreator, I've updated the Ticket section to show upcoming events first, followed by events ended. This functionality was already implemented

But i think cards shouldn't have background

@toffee-k21
Copy link
Contributor Author

But i think cards shouldn't have background

Hey @AceTheCreator , I have removed the background as you mentioned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the way the ticket section is being rendered
2 participants