fix implementation and test

asyncapi · May 1, 2024 · 8484a2d · 8484a2d
1 parent d1e64d6
commit 8484a2d
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 2 deletions.
diff --git a/src/generators/python/PythonConstrainer.ts b/src/generators/python/PythonConstrainer.ts
@@ -50,7 +50,8 @@ export const PythonDefaultTypeMapping: PythonTypeMapping = {
     const unionTypes = constrainedModel.union.map((unionModel) => {
       return unionModel.type;
     });
-    return unionTypes.join(' | ');
+    const uniqueSet = new Set(unionTypes);
+    return [...uniqueSet].join(' | ');
   },
   Dictionary({ constrainedModel }): string {
     return `dict[${constrainedModel.key.type}, ${constrainedModel.value.type}]`;

diff --git a/test/generators/python/PythonConstrainer.spec.ts b/test/generators/python/PythonConstrainer.spec.ts
@@ -199,6 +199,29 @@ describe('PythonConstrainer', () => {
       expect(type).toEqual('str');
     });
     test('should render multiple types', () => {
+      const unionModel1 = new ConstrainedStringModel(
+        'test',
+        undefined,
+        {},
+        'str'
+      );
+      const unionModel2 = new ConstrainedStringModel(
+        'test',
+        undefined,
+        {},
+        'str2'
+      );
+      const model = new ConstrainedUnionModel('test', undefined, {}, '', [
+        unionModel1,
+        unionModel2
+      ]);
+      const type = PythonDefaultTypeMapping.Union({
+        constrainedModel: model,
+        ...defaultOptions
+      });
+      expect(type).toEqual('str | str2');
+    });
+    test('should render unique types', () => {
       const unionModel1 = new ConstrainedStringModel(
         'test',
         undefined,
@@ -219,7 +242,7 @@ describe('PythonConstrainer', () => {
         constrainedModel: model,
         ...defaultOptions
       });
-      expect(type).toEqual('str | str');
+      expect(type).toEqual('str');
     });
   });