fix: bug with omitempty tag

asyncapi · May 23, 2024 · 89cb8e2 · 89cb8e2
1 parent 1c83912
commit 89cb8e2
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/examples/go-json-tags/__snapshots__/index.spec.ts.snap b/examples/go-json-tags/__snapshots__/index.spec.ts.snap
@@ -4,8 +4,8 @@ exports[`Should be able to render json-tags in struct and should log expected ou
 Array [
   "// Root represents a Root model.
 type Root struct {
-  Cities *Cities \`json:\\"cities, omitempty\\"\`
-  Options *Options \`json:\\"options, omitempty\\"\`
+  Cities *Cities \`json:\\"cities,omitempty\\"\`
+  Options *Options \`json:\\"options,omitempty\\"\`
 }",
 ]
 `;

diff --git a/src/generators/go/presets/CommonPreset.ts b/src/generators/go/presets/CommonPreset.ts
@@ -19,9 +19,9 @@ function renderJSONTag({
     field.property instanceof ConstrainedDictionaryModel &&
     field.property.serializationType === 'unwrap'
   ) {
-    return `json:"-"`;
+    return `json:"-",omitempty`;
   }
-  return `json:"${field.unconstrainedPropertyName}, omitempty"`;
+  return `json:"${field.unconstrainedPropertyName},omitempty"`;
 }
 
 function renderMarshallingFunctions({

diff --git a/test/generators/go/presets/__snapshots__/CommonPreset.spec.ts.snap b/test/generators/go/presets/__snapshots__/CommonPreset.spec.ts.snap
@@ -3,9 +3,9 @@
 exports[`GO_COMMON_PRESET should render json tags for structs 1`] = `
 "// Root represents a Root model.
 type Root struct {
-  StringProp string \`json:\\"stringProp, omitempty\\"\`
-  NumberProp float64 \`json:\\"numberProp, omitempty\\"\`
-  BooleanProp bool \`json:\\"booleanProp, omitempty\\"\`
+  StringProp string \`json:\\"stringProp,omitempty\\"\`
+  NumberProp float64 \`json:\\"numberProp,omitempty\\"\`
+  BooleanProp bool \`json:\\"booleanProp,omitempty\\"\`
 }"
 `;