Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: release version 2 #1112

Merged
merged 91 commits into from
Oct 17, 2023
Merged

feat!: release version 2 #1112

merged 91 commits into from
Oct 17, 2023

Conversation

jonaslagoni
Copy link
Member

@jonaslagoni jonaslagoni commented Jan 26, 2023 •
edited
Loading

2.0.0 (2023-10-16)

v2 generates more accurate types such as unions, and nullable and optional properties

You can read the migration guide here: https://www.modelina.org/docs/version-1-to-2

Modelina Breaking Changes

These are the potential breaking changes for Modelina itself, that might break the generation code:

Models Breaking Changes

These are the potential breaking changes for the generated models if you upgrade:

New Features

Bug Fixes

Performance Improvements

Other Changes

@sonarcloud
Copy link

sonarcloud bot commented Jan 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@netlify
Copy link

netlify bot commented Mar 21, 2023 •
edited
Loading

✅ Deploy Preview for modelina ready!

Name Link
🔨 Latest commit 2099df5
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/652ec1d9e7be5000082dc06c
😎 Deploy Preview https://deploy-preview-1112--modelina.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

kennethaasan and others added 16 commits March 23, 2023 12:51
@kennethaasan
fix!: fixes required properties when if/then/else is used (#1149)
3f5ea13
@asyncapi-bot
chore(release): v2.0.0-next.5 (#1184)
e46fb00
@jonaslagoni
Merge branch 'master-github-upstream' into update_with_master
c3aef77
@jonaslagoni
feat: update with master (#1185)
2640c3b
@jonaslagoni
chore: update with master
e5db3b7
@jonaslagoni
chore: update snapshot and packagelock
d85039f
@jonaslagoni
chore: update snapshot of example
450a151
@jonaslagoni
chore: merge branch master into update_next_with_master
70a2d4a
@jonaslagoni
feat: update next with master (#1204)
57e1d2e
@jonaslagoni
feat: force release (#1221)
c83a817
@asyncapi-bot
chore(release): v2.0.0-next.6 (#1222)
49e225f
@kennethaasan
feat!: handle const and discriminator (#1169)
32913ad 
* feat: handle const

* feat: handle const

* feat: handle const

* feat: handle const

* feat: handle const

* feat: handle const

* feat: handle const

* fixes bug when using oneOf in channel by not adding models to input model if they have already been scanned

* feat: handle const

* feat: handle const

* feat: handle const

* feat: handle const

* feat: handle const

* feat: handle const

* feat: handle const

* feat: set correct java quotes

* remove discriminator from CommonModel because we don't need it

* remove discriminator from CommonModel because we don't need it

* fixes review comments

* adds constant constrainers

* adds constant constrainers

* adds constant constrainers

* adds constant constrainers

* remove unused var
@asyncapi-bot
chore(release): v2.0.0-next.7 (#1242)
7d50cf4
@kennethaasan
fix!: should not carry over options from metaModel to constrainedModel (
284cc39 
#1243)
@asyncapi-bot
chore(release): v2.0.0-next.8 (#1247)
b044f20
@kennethaasan
docs: fixes constant constraints documentation (#1241)
175b321
@jonaslagoni
Copy link
Member Author

@Ferror @leigh-johnson @Samridhi-98 @magicmatatjahu @kennethaasan pinging you as after #1112 I plan to release v2, so this is a heads-up in case you have anything you want added beforehand 🙂

Right after the release I am gonna re-create the next branch so we can start breaking some more code if necessary 😆

@jonaslagoni jonaslagoni marked this pull request as ready for review October 12, 2023 19:53
@coveralls
Copy link

coveralls commented Oct 12, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6550637047

  • 572 of 598 (95.65%) changed or added relevant lines in 72 files are covered.
  • 4 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.1%) to 92.364%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/generators/cplusplus/constrainer/ConstantConstrainer.ts 2 3 66.67%
src/generators/csharp/constrainer/ConstantConstrainer.ts 2 3 66.67%
src/generators/dart/constrainer/ConstantConstrainer.ts 2 3 66.67%
src/generators/go/constrainer/ConstantConstrainer.ts 2 3 66.67%
src/generators/java/JavaDependencyManager.ts 10 11 90.91%
src/generators/java/constrainer/ConstantConstrainer.ts 18 19 94.74%
src/generators/java/renderers/ClassRenderer.ts 19 20 95.0%
src/generators/javascript/constrainer/ConstantConstrainer.ts 2 3 66.67%
src/generators/kotlin/constrainer/ConstantConstrainer.ts 2 3 66.67%
src/generators/php/constrainer/ConstantConstrainer.ts 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
src/generators/cplusplus/CplusplusGenerator.ts 1 75.0%
src/generators/python/PythonGenerator.ts 1 82.26%
src/interpreter/Interpreter.ts 1 93.2%
src/processors/AsyncAPIInputProcessor.ts 1 85.34%
Totals Coverage Status
Change from base Build 6536172638: 0.1%
Covered Lines: 5590
Relevant Lines: 5901
💛 - Coveralls

kennethaasan
kennethaasan previously approved these changes Oct 16, 2023
View reviewed changes
Ferror
Ferror previously approved these changes Oct 16, 2023
View reviewed changes
@jonaslagoni
Copy link
Member Author

jonaslagoni commented Oct 16, 2023 •
edited
Loading

I am gonna merge this tomorrow 👍

I am gonna update next with the latest master changes right before I release it (no need to re-approve) 🙂

@jonaslagoni jonaslagoni mentioned this pull request Oct 17, 2023
Merged
@jonaslagoni jonaslagoni dismissed stale reviews from Ferror and kennethaasan via b6d65be October 17, 2023 16:55
@sonarcloud
Copy link

sonarcloud bot commented Oct 17, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
4.8% 4.8% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@jonaslagoni jonaslagoni merged commit 26b29dc into master Oct 17, 2023
31 of 37 checks passed
@jonaslagoni jonaslagoni mentioned this pull request Oct 18, 2023
Merged
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jonaslagoni jonaslagoni deleted the next branch October 22, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennethaasan kennethaasan kennethaasan left review comments

@Ferror Ferror Ferror left review comments

@leigh-johnson leigh-johnson Awaiting requested review from leigh-johnson leigh-johnson is a code owner

@Samridhi-98 Samridhi-98 Awaiting requested review from Samridhi-98 Samridhi-98 is a code owner

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
autoupdate do-not-merge released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jonaslagoni @coveralls @asyncapi-bot @kennethaasan @Ferror @micro-jumbo @dlkj @Ksisa