feat!: add options as parameter to constraints #1667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for modelina ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
jonaslagoni
commented
Dec 19, 2023
| @@ -55,7 +56,7 @@ | |||
| "no-empty-character-class": 2, | |||
| "no-self-compare": 2, | |||
| "valid-typeof": 2, | |||
| "no-unused-vars": 0, | |||
| "unused-imports/no-unused-imports": 2, | |||
There was a problem hiding this comment.
Had to change lint rule because the old one did not understand --fix option
jonaslagoni
requested review from
Ferror,
leigh-johnson,
Samridhi-98,
magicmatatjahu,
kennethaasan and
asyncapi-bot-eve
as code owners
|
Thanks for the review folks 🙇 |
|
🎉 This PR is included in version 3.0.0-next.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
jonaslagoni
added a commit
that referenced
this pull request
Feb 1, 2024
* feat!: convert to use multi parser (#1587) * feat!: adds support for duration in java (#1604) * feat: enable AsyncAPI v3 (#1600) * fix!: add csharp support for DateTime, TimeSpan, Guid (#1612) * feat!: adds extend in common, meta, and constrained models (#1613) * feat!: adds inheritance with interfaces for java (#1593) * chore: remove duplicate version entry for AsyncAPI processor (#1609) * feat!: render python union in pydantic in the pre 3.10 way (#1626) * feat: add file path as input (#1601) * feat!: add options as parameter to constraints (#1667) * fix: (un)marshalling tuple and dictionary unwrapping for Typescript (#1717) * fix: jsonbinpack preset and runtime tests (#1718) * chore: fix linting * chore: remove unused directory * feat!: add useJavascriptReservedKeywords option for TS (#1727) * feat: enable raw properties for interface (#1729) * fix: newtonsoft could not handle enum values (#1731) * chore: update Java runtime tests (#1739) * fix: edge case where references was incorrect handled for JSON Schema (#1754) * fix: recursion bug for get nearest dependencies (#1757) --------- Co-authored-by: Kenneth Aasan <[email protected]> Co-authored-by: jano-petras <[email protected]> Co-authored-by: Nilkanth Parmar <[email protected]>
|
🎉 This PR is included in version 4.0.0-next.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds options as part of the constraint callbacks so you have direct access to them when the models are being constrained, i.e. for conditionally changing the behavior.
This is only a breaking change if you use the current constraint types in TS integrations.
Related issue(s)
Part of solving #1475