Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add resizable property in playground #1908

Closed
wants to merge 2 commits into from

Conversation

AKACHI-4
Copy link

Description

  • used react-resizable-panels to implement resizing into the editor and output components

File Changed

  • Content.tsx

Related issue(s)
Fixes #1846

Additionals
Playground _ Modelina

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

netlify bot commented Mar 22, 2024

Deploy Preview for modelina ready!

Name Link
🔨 Latest commit 92dd00d
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/660300c3b56a210008d6f37a
😎 Deploy Preview https://deploy-preview-1908--modelina.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Mar 26, 2024

Pull Request Test Coverage Report for Build 8440033043

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.303%

Totals Coverage Status
Change from base Build 8323576283: 0.0%
Covered Lines: 5994
Relevant Lines: 6325

💛 - Coveralls

@devilkiller-ag
Copy link
Member

Hi @AKACHI-4, There are few things we need to fix:

  • Can you please add a bar between the editors indicating that it can be resizeable? Something similar to this:
    image

  • Collapsing the left (input) editor should not collapse the general options.

  • Right editor along with output navigator is not being collapsed fully. Kindly fix this.

@jonaslagoni
Copy link
Member

@devilkiller-ag do you have time to take a look?

@devilkiller-ag
Copy link
Member

@devilkiller-ag do you have time to take a look?

Hi @jonaslagoni, I think I gave my review earlier on this 🤔

Copy link
Member

@devilkiller-ag devilkiller-ag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave my review here: #1908 (comment)

@AKACHI-4
Copy link
Author

Hey @devilkiller-ag, Surely look but first I have some thoughts

  • Can you please add a bar between the editors indicating that it can be resizable?

yea, sure. should it be more stylish as you suggested ?

  • Collapsing the left (input) editor should not collapse the general options.

yeah, got that. It should apply the same for the right panel as well.

  • Right editor along with output navigator is not being collapsed fully. Kindly fix this.

actually, I intentionally did that because when I completely collapse the right panel, there's no way I'll be able to use the resizable bar again since it will be hidden inside the overflow-y.

Possible fixes :

  • use low-opacity scrollbar for that.
  • use w-5 for the bar, but that might look too wide.

some observation : I checked vs-code, and its a fix there too. This means that in the 2-panel view, if we collapse right one, there's no way to get it back.

@AKACHI-4
Copy link
Author

kindly suggest some more improvement i can perform on pr.

Copy link

sonarcloud bot commented Mar 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@devilkiller-ag devilkiller-ag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be more stylish as you suggested ?
Yeah. I think it would be nice if we also add a button with an arrow icon at the center of the bar which can:

  • Reset the view.
  • The arrow icon should be towards right, when the output editor is taking the majority of view.
  • The arrow icon should be towards left, when the input editor is taking the majority of view.

It should apply the same for the right panel as well.

No, Because the output navigator is the part of output itself. There is no sense to change output files if you can't view them in the extreme case (when the output view is not visible).

@jonaslagoni jonaslagoni changed the title feat: added resizable property in playground chore: add resizable property in playground Mar 27, 2024
@devilkiller-ag
Copy link
Member

Any update on this @AKACHI-4?

@AKACHI-4
Copy link
Author

Hey @devilkiller-ag I will PR next week due to exam this week. tho

@devilkiller-ag
Copy link
Member

Hi @AKACHI-4, did you had a chance to look up on this work?

@AKACHI-4
Copy link
Author

Yeah @devilkiller-ag I did changes locally, but sort of incomplete what left is the arrow sign which changes direction on majority width.

Will do a raw commit by this evening.

@devilkiller-ag
Copy link
Member

devilkiller-ag commented May 6, 2024

Hi @AKACHI-4 any updates on this? Feel free to ask if you are facing any issues.

@devilkiller-ag
Copy link
Member

Hi @jonaslagoni, I am closing this PR since we have no updates from @AKACHI-4. I will share this issue with the community. If no one grabs it, then if time allows I will work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add Stretchable Sidebar to Playground
4 participants