-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add resizable property in playground #1908
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for modelina ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Pull Request Test Coverage Report for Build 8440033043Details
💛 - Coveralls |
Hi @AKACHI-4, There are few things we need to fix: |
@devilkiller-ag do you have time to take a look? |
Hi @jonaslagoni, I think I gave my review earlier on this 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave my review here: #1908 (comment)
Hey @devilkiller-ag, Surely look but first I have some thoughts
yea, sure. should it be more stylish as you suggested ?
yeah, got that. It should apply the same for the right panel as well.
actually, I intentionally did that because when I completely collapse the right panel, there's no way I'll be able to use the resizable bar again since it will be hidden inside the Possible fixes :
some observation : I checked vs-code, and its a fix there too. This means that in the 2-panel view, if we collapse right one, there's no way to get it back. |
kindly suggest some more improvement i can perform on pr. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it be more stylish as you suggested ?
Yeah. I think it would be nice if we also add a button with an arrow icon at the center of the bar which can:
- Reset the view.
- The arrow icon should be towards right, when the output editor is taking the majority of view.
- The arrow icon should be towards left, when the input editor is taking the majority of view.
It should apply the same for the right panel as well.
No, Because the output navigator is the part of output itself. There is no sense to change output files if you can't view them in the extreme case (when the output view is not visible).
Any update on this @AKACHI-4? |
Hey @devilkiller-ag I will PR next week due to exam this week. tho |
Hi @AKACHI-4, did you had a chance to look up on this work? |
Yeah @devilkiller-ag I did changes locally, but sort of incomplete what left is the arrow sign which changes direction on majority width. Will do a raw commit by this evening. |
Hi @AKACHI-4 any updates on this? Feel free to ask if you are facing any issues. |
Hi @jonaslagoni, I am closing this PR since we have no updates from @AKACHI-4. I will share this issue with the community. If no one grabs it, then if time allows I will work on it. |
Description
react-resizable-panels
to implement resizing into theeditor
andoutput
componentsFile Changed
Content.tsx
Related issue(s)
Fixes #1846
Additionals