Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: adds interface for oneOf objects with discriminator for go #1958

Merged
merged 6 commits into from
Apr 25, 2024
Merged

feat!: adds interface for oneOf objects with discriminator for go #1958

merged 6 commits into from
Apr 25, 2024

Conversation

kennethaasan
Copy link
Collaborator

@kennethaasan kennethaasan commented Apr 24, 2024 •
edited
Loading

Description

Adds interface for oneOf objects with discriminator for go

Related Issue

Checklist

  • The code follows the project's coding standards and is properly linted (npm run lint).
  • Tests have been added or updated to cover the changes.
  • Documentation has been updated to reflect the changes.
  • All tests pass successfully locally.(npm run test).

Additional Notes

@netlify Netlify
Copy link

netlify bot commented Apr 24, 2024 •
edited
Loading

✅ Deploy Preview for modelina canceled.

Name Link
🔨 Latest commit 68d0669
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/662a2b002b22bb0008cd5ade

@kennethaasan kennethaasan changed the title feat: adds interface for oneOf objects with discriminator for go feat!: adds interface for oneOf objects with discriminator for go Apr 24, 2024
@kennethaasan kennethaasan marked this pull request as ready for review April 24, 2024 14:28
jonaslagoni
jonaslagoni approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jonaslagoni
Copy link
Member

/rtm

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
8.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@asyncapi-bot asyncapi-bot merged commit 2c22282 into asyncapi:next Apr 25, 2024
15 of 16 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 4.0.0-next.32 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kennethaasan kennethaasan deleted the go-discriminator branch April 25, 2024 10:40
@kennethaasan kennethaasan mentioned this pull request Apr 25, 2024
Merged
4 tasks
jonaslagoni added a commit to jonaslagoni/generator-model-sdk that referenced this pull request Apr 29, 2024
@kennethaasan @jonaslagoni
feat!: adds interface for oneOf objects with discriminator for go (as…
3e6330c 
…yncapi#1958)

Co-authored-by: Jonas Lagoni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaslagoni jonaslagoni jonaslagoni approved these changes

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released on @next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kennethaasan @jonaslagoni @asyncapi-bot