-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: treat nullable property as optional #2001
fix: treat nullable property as optional #2001
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for modelina canceled.
|
Quality Gate passedIssues Measures |
Pull Request Test Coverage Report for Build 9111354819Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @janne-slamcore 🤙
@all-contributors please add @janne-slamcore for code, test |
I've put up a pull request to add @janne-slamcore! 🎉 |
🎉 This PR is included in version 3.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Add a test for a required, but nullable, union type and update the Pydantic preset to treat nullable properties as optional.
Related Issue
Fixes #2000
Checklist
npm run lint
).npm run test
).