-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add go omitempty json tag #2004
Conversation
✅ Deploy Preview for modelina canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think this should be having it's own option, it's required for the json tags to correctly work IMO 🤔
Why would you like to have it as an option @Souvikns?
It needs |
The problem as I see it with adding it as an option is that it currently (by default) creates incorrect JSON Data as soon as you have an optional property or null type. To me this is a bug rather then a missing feature 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got some snapshots that are not happy ✌️
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
🎉 This PR is included in version 4.0.0-next.40 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
This PR is adding a new option for
GO_COMMON_PRESET
for generatingomitempty
parameter.Related Issue
Checklist
npm run lint
).npm run test
).Additional Notes