Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: switch CLI run scripts to cjs #2015

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

jonaslagoni
Copy link
Member

@jonaslagoni jonaslagoni commented May 22, 2024

Description

There was a mismatch between the CLI being built for cjs but the run scripts was esm which means they were incompatible, this fixes that it cannot be run at all

Copy link

netlify bot commented May 22, 2024

Deploy Preview for modelina canceled.

Name Link
🔨 Latest commit 039b66a
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/665d777c1a96a20008a59471

@jonaslagoni jonaslagoni changed the title fix: switch CLI run scripts to cjs chore: switch CLI run scripts to cjs Jun 2, 2024
Copy link

sonarcloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jonaslagoni jonaslagoni changed the title chore: switch CLI run scripts to cjs fix: switch CLI run scripts to cjs Jun 3, 2024
@jonaslagoni jonaslagoni merged commit c226633 into asyncapi:next Jun 3, 2024
17 checks passed
@jonaslagoni jonaslagoni deleted the switch_cli_to_cjs branch June 3, 2024 09:01
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 4.0.0-next.46 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants