Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update json tag for Fixing #2018

Merged
merged 3 commits into from
May 29, 2024
Merged

Conversation

Souvikns
Copy link
Member

Description

Having a bug with additional properties not getting omitted and also has an extra ModelinaAnytype

      "EmailSent": {
        "ModelinaAnyType": null, // Extra type getting generated
        "payload": {
          "required": ["email", "timestamp"],
          "additionalProperties": {}, // Solved by fixing json tag
          "properties": {
            "email": {
              "description": "Email of the user",
              "type": "string",
              "format": "email"
            },
            "timestamp": { "type": "string", "format": "date-time" }
          },
          "type": "object"
        }
      }

Related Issue

Checklist

  • The code follows the project's coding standards and is properly linted (npm run lint).
  • Tests have been added or updated to cover the changes.
  • Documentation has been updated to reflect the changes.
  • All tests pass successfully locally.(npm run test).

Additional Notes

Copy link

netlify bot commented May 29, 2024

Deploy Preview for modelina canceled.

Name Link
🔨 Latest commit 36197ab
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/6656a524aaf1c80008297188

Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jonaslagoni jonaslagoni merged commit 9952ad2 into asyncapi:next May 29, 2024
23 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 4.0.0-next.45 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants