-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update next-spec branch with master changes #606
chore: update next-spec branch with master changes #606
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
@fmvilas @derberg @jonaslagoni @magicmatatjahu can you please look into this PR. It's part of 2.5.0 release effort and updates the release branch ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strange to see changes only in package-lock.json
GH is not able to load diff for me, what is in there?
@derberg there was conflict in $ npm i --verbose --legacy-peer-deps |
@char0n weird, there should not be any conflicts, we should just take 1:1 what is in the |
6f2f015
to
384ad21
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@derberg you can try for yourself by checking into Anyway, I've tried to eliminate the |
And the windows memory test is now passing as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
/rtm |
🎉 This PR is included in version 1.17.0-next-spec.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.17.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 2.0.0-next-major.18 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This is PR is part of asyncapi/spec#830 and updates
next-spec
branch with changes frommaster
.