You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
The tests can be run with pnpm test. It works for my tests but for some reason, it fails the tests written in studio-next/src/services/tests. The stack trace is as follows:
FAIL src/services/tests/navigation.service.test.ts
● Test suite failed to run
Cannot find module '@/helpers' from 'src/components/common/Dropdown.tsx'
Require stack:
src/components/common/Dropdown.tsx
src/components/common/index.ts
src/components/Modals/Generator/TemplateParameters.tsx
src/components/Modals/Generator/GeneratorModal.tsx
src/components/Modals/index.tsx
src/services/app.service.ts
src/services/index.ts
src/services/tests/navigation.service.test.ts
1 | import { useState, useRef } from 'react';
2 |
> 3 | import { useOutsideClickCallback } from '@/helpers';
| ^
4 |
5 | import type { FunctionComponent, PropsWithChildren, ReactNode } from 'react';
6 |
at Resolver._throwModNotFoundError (../../node_modules/.pnpm/[email protected]/node_modules/jest-resolve/build/resolver.js:427:11)
at Object.<anonymous> (src/components/common/Dropdown.tsx:3:1)
at Object.<anonymous> (src/components/common/index.ts:3:1)
at Object.<anonymous> (src/components/Modals/Generator/TemplateParameters.tsx:4:1)
at Object.<anonymous> (src/components/Modals/Generator/GeneratorModal.tsx:7:1)
at Object.<anonymous> (src/components/Modals/index.tsx:1:1)
at Object.<anonymous> (src/services/app.service.ts:5:1)
at Object.<anonymous> (src/services/index.ts:5:1)
at Object.<anonymous> (src/services/tests/navigation.service.test.ts:1:1)
Can someone point me to the right direction of how I should go about resolving the issue?
I'm 🧞🧞🧞 Genie 🧞🧞🧞 from the magic lamp. Looks like somebody needs a hand!
At the moment the following comments are supported in pull requests:
- `/please-take-a-look` or `/ptal` - This comment will add a comment to the PR asking for attention from the reviewrs who have not reviewed the PR yet.
- `/ready-to-merge` or `/rtm` - This comment will trigger automerge of PR in case all required checks are green, approvals in place and do-not-merge label is not added
- `/do-not-merge` or `/dnm` - This comment will block automerging even if all conditions are met and ready-to-merge label is added
- `/autoupdate` or `/au` - This comment will add `autoupdate` label to the PR and keeps your PR up-to-date to the target branch's future changes. Unless there is a merge conflict or it is a draft PR. (Currently only works for upstream branches.)
- `/update` or `/u` - This comment will update the PR with the latest changes from the target branch. Unless there is a merge conflict or it is a draft PR. NOTE: this only updates the PR once, so if you need to update again, you need to call the command again.
Closing this PR in favor of the suggestion made by @smoya in this comment here: #1130 (comment). The contents of this PR can be found in the main PR i.e. #1122
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added tests for the dynamic open graph tags added in #1122 using jest.