feat: add Visual JSON Schema Editor #905
Conversation
|
✅ Deploy Preview for modest-rosalind-098b67 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for asyncapi-studio-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
princerajpoot20
force-pushed
the
message-schema
branch
from
83ef1ca
to
f8d508a
Compare
|
@asyncapi/bounty_team |
|
@princerajpoot20 |
princerajpoot20
force-pushed
the
message-schema
branch
from
4f6d5b4
to
b2a619c
Compare
Update
What's left:
|
Currently working on:I am working on resolving type error that is causing the build to fail, though it runs on my local machine. |
princerajpoot20
changed the title
|
Is something blocking this PR from merging, though the functionality is not finished, but agreed to be merged 'as is?' |
|
/rtm |
|
@princerajpoot20 could you check @fmvilas suggestion: #905 (comment) if it's not relevant anymore let him know so he can approve as well We can merge "as is" and make a new iteration to adjust it. |
There was a problem hiding this comment.
I'm confused. I'm trying to use the component in the design system (in Storybook) and it doesn't work when I try to remove fields or mark them as required. Is it a thing of how we're integrating it in Storybook or is it a thing of the component? Would love to see it working completely as if it was in the real app.
Also, the design still needs some work. We should make it match the proposed design IMHO.
That said, I'm not a code owner of Studio. If code owners think we should merge this, I'm happy to dismiss my review. That's totally fine, we can address these issues later down the track. Just wanted to highlight the things I'm seeing.
There was a problem hiding this comment.
Just got a DM from @princerajpoot20 explaining the situation:
I’ve discussed this with Samir, and we’ve decided to complete it in two iterations.
We’ve adjusted the complexity of the bounty from advanced to two medium bounties.
I have completed the first iteration, and the second iteration is scheduled for Q2 of 2024 (Link for 2nd iteration).
This iteration will include all remaining tasks, such as deletion, toggling between required/not required, and UI changes. Hence we are merging the current progress now and will complete the remainder in the second iteration.
Approving! 👍
|
|
/rtm |
Adding Visual JSON Schema Editor
Resolves: #755