Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: about this guide page #1291

Closed
wants to merge 35 commits into from
Closed

Conversation

thulieblack
Copy link
Member

@thulieblack thulieblack commented Feb 2, 2023

This PR adds the new About This Guide page to the style guide folder.

Resolves #1243

@netlify
Copy link

netlify bot commented Feb 2, 2023

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f8ded38
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/640ad7c97abb320007a65864
😎 Deploy Preview https://deploy-preview-1291--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@thulieblack thulieblack marked this pull request as ready for review February 8, 2023 16:14
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 52
🟠 Accessibility 88
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1291--asyncapi-website.netlify.app/

@quetzalliwrites quetzalliwrites added 📑 docs area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. labels Feb 10, 2023
Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1st review round done 😄✌🏽💪🏿

thank you for your lovely work! ✨✨✨

thulieblack and others added 15 commits February 22, 2023 12:05
@akshatnema
Copy link
Member

ping @alequetzalli

Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, still need a few more things...

@quetzalliwrites
Copy link
Member

oops! I also forgot to remind you earlier that for the netlify preview link to generate, it needs:

  1. _sections.md
  2. index.md

Screen Shot 2023-03-06 at 6 34 26 PM

Screen Shot 2023-03-06 at 6 35 35 PM

➡️➡️ can you add those to your PR and lemme know if that fixes the lack of preview link? :) I see that @BhaswatiRoy seems to have successfully done it for her PR https://github.com/asyncapi/website/pull/1327/files

@thulieblack thulieblack deleted the about_page branch March 10, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. 📑 docs
Projects
Status: Community PR under Review 🧐
Development

Successfully merging this pull request may close these issues.

docs: new style guide - About this guide
3 participants