Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: new aboutguide page #1419

Closed
wants to merge 0 commits into from
Closed

Conversation

thulieblack
Copy link
Member

This PR adds the new About This Guide page under the style guide folder.

Resolve #1243

@netlify
Copy link

netlify bot commented Mar 10, 2023

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 09fa454
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/65b77392dc01f600089fae05
😎 Deploy Preview https://deploy-preview-1419--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thulieblack
Copy link
Member Author

Hey, @alequetzalli I had to create new branches. I hope everything is now working as it should

@github-actions
Copy link

github-actions bot commented Mar 10, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 31
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1419--asyncapi-website.netlify.app/

@quetzalliwrites
Copy link
Member

quetzalliwrites commented Mar 14, 2023

... I had to create new branches

darn it! I had a feeling that would be the case 😬

@@ -0,0 +1,25 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of course you remembered to add the overview page! i LOVE YOU, you are sooo good at paying attention to the little details! ✨😄

quetzalliwrites
quetzalliwrites previously approved these changes Jun 7, 2023
Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This guide is very well done and covers many important points for writing high-quality documentation! Your document is very comprehensive and well-structured, providing a great starting point for new contributors. ✨

@quetzalliwrites quetzalliwrites added do-not-merge 📑 docs area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. labels Jun 7, 2023
@quetzalliwrites
Copy link
Member

IMHO, this is ready to merge @thulieblack.

However, please note that while I have approved this PR, I added a do not merge label because I think we need to create a feature branch for the Community Docs Style Guide work. Ideally, I think it makes more sense to have you and the other Style Guide contributors merge their work to a feature branch first, and then once all style guide content is done/ready in the feature branch and reviewed... we merge that feature branch to MAIN branch. (Let me know if that doesn't make sense.)

I just need to figure out how we do that first, so I will get back to you on this. I think we may need to just ask @AceTheCreator maybe? I think he already did this before see he can prob give instructions on how to proceed on creating a feature branch for us and how merging that works.

@asyncapi-bot
Copy link
Contributor

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 44
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-1419--asyncapi-website.netlify.app/

@thulieblack thulieblack deleted the aboutguide branch January 29, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. do-not-merge 📑 docs
Projects
Status: Community PR under Review 🧐
Development

Successfully merging this pull request may close these issues.

docs: new style guide - About this guide
3 participants