-
-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: new aboutguide page #1419
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey, @alequetzalli I had to create new branches. I hope everything is now working as it should |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1419--asyncapi-website.netlify.app/ |
darn it! I had a feeling that would be the case 😬 |
pages/docs/community/index.md
Outdated
@@ -0,0 +1,25 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
of course you remembered to add the overview
page! i LOVE YOU, you are sooo good at paying attention to the little details! ✨😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This guide is very well done and covers many important points for writing high-quality documentation! Your document is very comprehensive and well-structured, providing a great starting point for new contributors. ✨
IMHO, this is ready to merge @thulieblack. However, please note that while I have approved this PR, I added a I just need to figure out how we do that first, so I will get back to you on this. I think we may need to just ask @AceTheCreator maybe? I think he already did this before see he can prob give instructions on how to proceed on creating a feature branch for us and how merging that works. |
f9d459e
to
09fa454
Compare
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1419--asyncapi-website.netlify.app/ |
This PR adds the new About This Guide page under the style guide folder.
Resolve #1243