Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added test for build-rss.js #3101
feat: added test for build-rss.js #3101
Changes from 54 commits
63e8bf5
c2570b9
30f1c7f
aad7bf2
312d4c5
8d7269a
cfd547f
5859c79
44c3b63
de5edec
bf10b10
1bacff6
3ce90ca
5d8fb67
198c2a4
5f4d05b
5ab37aa
81b9845
92e86a3
0d0cb30
d7e0ac1
fc57c2a
1a8aa47
5ddb184
5e8c0c7
1eb6790
b03191d
239e65b
5e98d50
45f6ef6
e6258c5
7c9730f
6e9f039
aac6e13
0f61abe
e06fa47
bc67c28
8c93997
6e0b4ce
2631dc6
a66f2a2
a51c362
4eb10e3
4e75b0a
5892f1e
e04cfba
07b2344
d55f553
d9585fe
d41b851
d5b6882
7980458
6a93919
a5c083b
49f308a
a4903ef
1ab85ee
36e7511
1d39693
8a55fa2
2ee9f6f
6804d6e
fd0bb07
17fd825
8f77c30
a3dfa93
968d071
7b1f401
87eb06b
2312a57
d77cf7a
bc76d4b
5407af0
fb49686
1d13e0b
3837d4b
51fc2a3
9e166ae
02d5c07
fed5650
8d0ff17
d9ce3ab
08c88ae
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consider using asynchronous file operations in setup and teardown
In the
beforeAll
andafterAll
hooks, synchronous file operations likefs.mkdirSync
,fs.readdirSync
,fs.unlinkSync
, andfs.rmdirSync
are used. While this is acceptable for small tests, using asynchronous versions can improve performance and prevent blocking the event loop.You can refactor the setup and teardown to use asynchronous methods:
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vishvamsinh28 Apply this suggestion if it doesn't breaks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akshatnema Done