-
-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: broken link to generator github actions (Fixes #3190) #3217
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3217--asyncapi-website.netlify.app/ |
@TRohit20 can you please take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noticing and fixing the broken link @hkv24
LGTM! @sambhavgupta0705
@TRohit20 No worries man! |
@quetzalliwrites PTAL |
WalkthroughThe pull request includes updates to two markdown documents related to AsyncAPI, primarily focusing on correcting links and descriptions for GitHub Actions. The links have been changed to reflect a new generator action, and additional information regarding npm scopes for React and web components has been added. The overall structure of the documents remains the same, with no changes made to the YAML examples. Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3217 +/- ##
=======================================
Coverage 86.59% 86.59%
=======================================
Files 21 21
Lines 664 664
=======================================
Hits 575 575
Misses 89 89 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hkv24
🚢
/update |
/rtm |
Description
This PR fixes a broken link in the AsyncAPI Generator Installation Guide. The outdated link to the GitHub Marketplace Action for AsyncAPI documents needs to be updated with the correct URL.
Current Link: https://github.com/marketplace/actions/generator-for-asyncapi-documents
Updated Link: https://github.com/marketplace/actions/generator-validator-converter-and-others-all-in-one-for-your-asyncapi-docs
Resolves #3190
Summary by CodeRabbit