Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added loading state and adjusted tweet height in TwitterTimelineEmbed #3256

Closed
wants to merge 2 commits into from
+22 −2
Closed

Added loading state and adjusted tweet height in TwitterTimelineEmbed #3256

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74bcb94
Added loading state and adjusted tweet height in TwitterTimelineEmbed
oscar2104 Sep 25, 2024
71fe576
Fix twitter timeline
oscar2104 Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions components/newsroom/Newsroom.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
import React, { useState } from 'react';

import { TwitterTimelineEmbed } from 'react-twitter-embed';

import { HeadingLevel, HeadingTypeStyle } from '@/types/typography/Heading';
import { ParagraphTypeStyle } from '@/types/typography/Paragraph';

import Loader from '../Loader';
import ArrowRight from '../icons/ArrowRight';
import Heading from '../typography/Heading';
import Paragraph from '../typography/Paragraph';
Expand All @@ -11,10 +14,14 @@ import NewsroomArticle from './NewsroomArticle';
import NewsroomBlogPosts from './NewsroomBlogPosts';
import NewsroomYoutube from './NewsroomYoutube';


/**
* @description This component displays the latest updates, blog posts, news, and videos.
*/
export default function Newsroom() {

const [loading, setLoading] = useState(true);

return (
<>
<div className='mt-12 text-center' data-testid='Newsroom-main'>
Expand Down Expand Up @@ -77,8 +84,21 @@ export default function Newsroom() {
</div>
</div>
<div className='w-full px-2 md:w-1/2 md:pl-4 md:pr-0'>
<div className='mx-auto mt-8 w-full rounded-xl shadow-md md:mt-0' data-testid='Newsroom-Twitter'>
<TwitterTimelineEmbed sourceType='profile' screenName='AsyncAPISpec' options={{ tweetLimit: '2' }} />
<div className='mx-auto mt-8 w-full rounded-xl shadow-md md:mt-0' style={{ height: '500px' }} data-testid='Newsroom-Twitter'>
{loading && (
<Loader
loaderText="Loading Twitter feed..."
className="h-full"
pulsating={true}
dark={false}
/>
)}
<TwitterTimelineEmbed
sourceType="profile"
screenName="AsyncAPISpec"
options={{ tweetLimit: '2', height: '500' }}
onLoad={() => setLoading(false)}
/>
</div>
</div>
</div>
Expand Down
Loading