Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OG Image: updated _app.tsx #103

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

jjung99
Copy link

@jjung99 jjung99 commented Oct 18, 2021

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # 25

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

It has been tested by the visual studio for compilation and preview URL through PR for output

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@vercel
Copy link

vercel bot commented Oct 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/thoughtdump/webapis-playground/FN8spgbodDQLr7tmSZUZC2zK6HTT
✅ Preview: https://webapis-playground-git-fork-jjung99-issue-25-300ed0-thoughtdump.vercel.app

@jjung99
Copy link
Author

jjung99 commented Oct 18, 2021

Hi, I only changed one file which is _app.tsx file and added few lines in it for facebook OG image.
I just tested it and it worked!
testPng

@atapas
Copy link
Owner

atapas commented Oct 18, 2021

@jjung99 Great,

Could you please summarize it with the list of platforms you have tested and found to be working with the latest code? Screenshots of them would be great.

  • Twitter
  • LinkedIn
  • Reddit
  • Facebook

@jjung99
Copy link
Author

jjung99 commented Oct 18, 2021

Platforms for testing with screenshot

  • Twitter
    twitter test

  • LinkedIn
    linkedin test

  • Reddit
    reddit test

  • Facebook
    facebook test

@atapas
Copy link
Owner

atapas commented Oct 18, 2021

Platforms for testing with screenshot

  • Twitter
    twitter test
  • LinkedIn
    linkedin test
  • Reddit
    reddit test
  • Facebook
    facebook test

So it is mostly fixed except LinkedIn where it shows @max-programming's DP 😂. Can we fix that too?

@jjung99
Copy link
Author

jjung99 commented Oct 18, 2021

I will try to fix it within today! lol

@atapas atapas linked an issue Oct 18, 2021 that may be closed by this pull request
@max-programming
Copy link
Collaborator

I think I'm famous 😂

@atapas
Copy link
Owner

atapas commented Oct 20, 2021

I will try to fix it within today! lol

@jjung99 is it done?

@jjung99
Copy link
Author

jjung99 commented Oct 20, 2021

The way the LinkedIn brings og image is different I think. I actually have midterms tomorrow so Can you give me couple of extra days?

@atapas
Copy link
Owner

atapas commented Oct 20, 2021

The way the LinkedIn brings og image is different I think. I actually have midterms tomorrow so Can you give me couple of extra days?

Yeah plz, take your time.. Just let me know when ready!

@jjung99
Copy link
Author

jjung99 commented Oct 20, 2021

Thanks for understanding. I will start to work on it as soon as the tests are done!

@Michae645j
Copy link

Please I need to update my ogwhatsapp

@Michae645j
Copy link

Screenshot_20211023-225740_OGWhatsApp

@atapas atapas changed the title updated _app.tsx OG Image: updated _app.tsx Oct 26, 2021
@atapas
Copy link
Owner

atapas commented Oct 27, 2021

Hey @jjung99 Any update?

@atapas
Copy link
Owner

atapas commented Nov 23, 2021

@jjung99 would you make any further changes to it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Fix OG Image issues of the website/app
5 participants