Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates and Fixes for Compatibility with Node.js > 16, Next.js 13, and Dependency Enhancements #192

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

Tejs1
Copy link

@Tejs1 Tejs1 commented Aug 7, 2024

Description

This pull request includes a series of updates and fixes to enhance the functionality and compatibility of the project. The changes span various areas including refactoring, dependency updates, and bug fixes. The primary motivation for these changes is to ensure compatibility with Node versions greater than 16, addressing issues related to the deprecation and removal of some legacy cryptographic algorithms and their associated APIs.

Fixes # issue #191

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Reviewed and tested the NetworkInformation interface and Navigator type changes to ensure proper functionality.
  • Verified that the hydration mismatch issue in the Card component is resolved.
  • Tested the application with the updated dependencies to ensure there are no compatibility issues.
  • Validated the changes made to the Header component using Next.js Link.
  • Confirmed the proper integration and functionality of next-pwa with Next.js.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

raveenita and others added 12 commits August 7, 2024 05:52
The `next.js` dependency has been updated from version 11.1.2 to 12.3.4, and the `nextjs-progressbar` dependency has been updated from version 0.0.11 to 0.0.16. This update ensures that we are using the latest stable versions of these packages.
- Updated next.config.js to use correct next-pwa syntax
- Ensured compatibility between next-pwa and Next.js versions
This commit updates the TypeScript dependency from version 4.5.2 to 4.9.5. It also updates other dependencies such as `@types/react`, `@types/react-dom`, and `@types/webrtc` to their latest versions. This update ensures that we are using the latest stable versions of these packages and improves compatibility with other libraries and frameworks.

```
- Move clsx to dependencies and upgrade to v2.1.1
  * Now used in runtime code for dynamic className management
- Add @types/eslint and @types/node devDependencies for improved TypeScript support
- Removed `as="a"` from Button component inside Link to avoid hydration mismatch
- Ensured proper rendering during server-side and client-side rendering by leveraging Next.js 13's behavior where <Link> always renders <a>

This change addresses the issue where the Button component was rendered as a button element on the server side and as an anchor element on the client side, causing a hydration mismatch.
- Updated the NetworkInformation interface to include additional properties: downlinksMax and saveData
- Updated the Navigator type to include a connection property of type NetworkInformation
- These changes ensure that the NetworkInformation interface and Navigator type accurately reflect the properties and structure of the network information data
Copy link

vercel bot commented Aug 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
webapis-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 8:35am

@Tejs1
Copy link
Author

Tejs1 commented Aug 7, 2024

@atapas Hey can you review the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants