Smart plugs: add ID for power button #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If your wanting to get this added in, I would suggest that you also add this into the: v1 Plug: https://github.com/athom-tech/athom-configs/blob/main/athom-smart-plug.yaml v3 Plug: https://github.com/athom-tech/esp32-configs/blob/main/athom-smart-plug.yaml to ensure consistency of the functionality / code between ALL versions of the plug. Previously this was lacking, but in the last few months was just fixed up. |
Setting an ID for the power button allows its behavior to be extended or
modified by configuration that uses this package, for example:
packages:
Athom_Technology.Smart_Plug_V2: github://athom-tech/athom-configs/athom-smart-plug-v2.yaml
binary_sensor:
- id: !extend power_button
# Additional settings here
tari
force-pushed
the
plug-v2-button-id
branch
from
611ac5a
to
f19935c
Compare
tari
changed the title
|
That's reasonable. Added the same change to v1 here, and v3 in athom-tech/esp32-configs#27. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting an ID for the power button allows its behavior to be extended or modified by configuration that uses this package, for example: