Skip to content

Commit

Permalink
ext-fwft: use uint32_t type for feature parameters
Browse files Browse the repository at this point in the history
As reported on github [1], the feature types values are described as 32
bits identifiers but declared as unsigned long in function arguments. Use
uint32_t for the parameters types to be coherent.

Link: riscv-non-isa#174 [1]

Reviewed-by: Andrew Jones <[email protected]>
Reviewed-by: Atish Patra <[email protected]>
Signed-off-by: Clément Léger <[email protected]>
  • Loading branch information
clementleger authored and atishp04 committed Oct 29, 2024
1 parent 4542d28 commit a676827
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/ext-firmware-features.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ description. Upon system reset, global and local feature values are reset.

[source, C]
----
struct sbiret sbi_fwft_set(unsigned long feature,
struct sbiret sbi_fwft_set(uint32_t feature,
unsigned long value,
unsigned long flags)
----
Expand Down Expand Up @@ -161,7 +161,7 @@ switch if delegation choices are different between Host and Guest/VM.

[source, C]
----
struct sbiret sbi_fwft_get(unsigned long feature)
struct sbiret sbi_fwft_get(uint32_t feature)
----

A successful return from `sbi_fwft_get()` results in the firmware
Expand Down

0 comments on commit a676827

Please sign in to comment.