Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Originally,
publish_ios
was triggered by the tag, and creates the release (using the tag), so that it can upload the ios assets to the release.publish.yml
was triggered by a push to release branch because it uploads to Artifactory, which only allows uploads from the release branch.Now that I've changed both to trigger on a push to release branch, the ios one is failing because there is no tag.
Changes
I've merged
publish_ios.yml
andpublish.yml
into 1 file. When there is a push to release branch, it will automatically tag the commit, publish to artifactory and upload assets to the newly created Github release.Thanks to @tchernykh for all the ideas/help!
Testing
I've tested the workflow (without the Artifcatory publishing, because that's restricted to
release
branch) on my branch and it works as expected.