Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically tag release branch #43

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Automatically tag release branch #43

merged 2 commits into from
Oct 18, 2024

Conversation

nlam-atlassian
Copy link
Collaborator

Problem

Originally, publish_ios was triggered by the tag, and creates the release (using the tag), so that it can upload the ios assets to the release.
publish.yml was triggered by a push to release branch because it uploads to Artifactory, which only allows uploads from the release branch.
Now that I've changed both to trigger on a push to release branch, the ios one is failing because there is no tag.

Changes

I've merged publish_ios.yml and publish.yml into 1 file. When there is a push to release branch, it will automatically tag the commit, publish to artifactory and upload assets to the newly created Github release.

Thanks to @tchernykh for all the ideas/help!

Testing

I've tested the workflow (without the Artifcatory publishing, because that's restricted to release branch) on my branch and it works as expected.

@nlam-atlassian nlam-atlassian merged commit 1a78737 into main Oct 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants