Release version 1.1.2 #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Douglas Marques <[email protected]>
- Jsoup library should be exposed as API, otherwise clients need to declare it as well - JSON parser was not exposed - Plugin.appendTransaction was not exposed - State.applyTransaction should not be private - Created safeMode flag to avoid fatal crashes in some transactions when the flag is ON - Bump version to 1.0.1 --------- Co-authored-by: Douglas Marques <[email protected]>
Modularising our ProseMirror implementation similar to the web version. This enhancement will result in having one JAR file per module, eliminating the requirement for clients to include the entire ProseMirror codebase in their applications - they will only add what is necessary. Additionally, this modification will make available the test-builder module that was previously not accessible since it was within a test folder. --------- Co-authored-by: Douglas Marques <[email protected]>
…ash (#9) The fix for String.IndexOutOfBounds crash. It is a slight change of String.slice method implementation to behave the same way that web version have. It is still not exactly the same but we don’t need special cases of handling negative indices
Co-authored-by: Douglas Marques <[email protected]>
Initial support for using kotlin multiplatform added. First module (util) is converted. Co-authored-by: Aleksei Chernykh <[email protected]>
Disabled configuration caching on publish script
- Adding gradle system property to make repo allow SHA-512 - Bump version to 1.4
KSoup is used instead of JSoup as a step to convert remaining modules to multiplatform. Co-authored-by: Aleksei Chernykh <[email protected]>
Co-authored-by: Aleksei Chernykh <[email protected]>
There is no `java.util.concurrent` for multiplatform, so had to use alternatives. Co-authored-by: Aleksei Chernykh <[email protected]>
No actual changes, just source and test directories renamed. This will allow to see actual changes for multiplatform conversion. Co-authored-by: Aleksei Chernykh <[email protected]>
Co-authored-by: Aleksei Chernykh <[email protected]>
Automatic release, prepare and publish iOS artifact to release. Here is sample release created by those scripts: https://github.com/atlassian-labs/prosemirror-kotlin/releases/tag/1.0.4 --------- Co-authored-by: Aleksei Chernykh <[email protected]>
This was converted from TS incorrectly, the TS is: if (!copy) copy = marks.slice(0, i) and the docs for slice is: 
Converting some tests from TS
Most of the original code was from v1.18.1, but FromDom and ToDom was from a newer version. So I have updated the whole model module to v1.22.3. I haven't converted all the tests in v1.22.3 yet. They are commented out in the code, so that I can convert them later. This PR has a breaking change: `ParseRuleImpl` has been replaced with `TagParseRuleImpl` and `StyleParseRuleImpl`. This change was made in v1.20.0.
…or-schema-list (#29) Bumping the test modules because some of the new tests depend on it. There are lots more tests to convert, but I've just converted a few more in this PR to make sure that we have what we need in the test modules.
Handle null/wrong type attrs more gracefully, especially when attr is going into a non-nullable field. I've cleaned up the tests and updated the javadocs/comments a bit compared to the changes for ME-5482 on the old repo, but the logic is the same.
Implemented custom platform version of JS WeakMap. Context: #28 (comment)
See CONTRIBUTING.md for details. Merging into and tagging the `release` branch is now deprecated. We will be tagging the `main` branch with releases
Converted all remaining tests in DomTests
Clean up readme files so that the dependency instructions are at the top level, and not tied to a specific version.
We might need to read some of the `unknownFields`stored on Node to provide extra attributes to some Nodes. An example is the Doc.version - it wasn't defined as a node attribute, so we need to read `unknownFields` and populate a new field to expose the version.
Revert the previous change to workflows for publishing. Now, publishing is triggered by a push to `release` branch. We revert back to releasing and tagging on the `release` branch because that was a security issue with releasing from a tag.
### Problem Originally, `publish_ios` was triggered by the tag, and creates the release (using the tag), so that it can upload the ios assets to the release. `publish.yml` was triggered by a push to release branch because it uploads to Artifactory, which only allows uploads from the release branch. Now that I've changed both to trigger on a push to release branch, the ios one is failing because there is no tag. ### Changes I've merged `publish_ios.yml` and `publish.yml` into 1 file. When there is a push to release branch, it will automatically tag the commit, publish to artifactory and upload assets to the newly created Github release. Thanks to @tchernykh for all the ideas/help! ### Testing I've tested the workflow (without the Artifcatory publishing, because that's restricted to `release` branch) on my branch and it works as expected.
nlam-atlassian
requested review from
tchernykh,
douglasmarques and
encryptededdy
tchernykh
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.