Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark 0.3.7 release #30

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Mark 0.3.7 release #30

merged 1 commit into from
Sep 12, 2023

Conversation

mgrzaslewicz
Copy link
Contributor

No description provided.

@mgrzaslewicz mgrzaslewicz requested a review from a team as a code owner September 12, 2023 08:18

## [0.3.7] - 2023-09-11
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing link to the 0.3.7. Also missing for 2 previous releases.

Suggested change
## [0.3.7] - 2023-09-11
## [0.3.7] - 2023-09-11
[0.3.7]: https://github.com/atlassian/docker-infrastructure/compare/release-0.3.6...release-0.3.7

Copy link

@pczuj pczuj Sep 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird... the last tag we have is release-0.3.5, so we don't have release-0.3.6 and release-0.3.7

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

[JPERF-836]: https://ecosystem.atlassian.net/browse/JPERF-836

## [0.3.5] - 2022-10-13
### Changed
- Update Jira license [JPERF-836]
- Update testcontainers to 1.17.5 as old ryuk image wasn't available in dockerhub anymore

[0.3.5]: https://github.com/atlassian/docker-infrastructure/compare/release-0.3.4...release-0.3.5
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: We used to put those directly under the version header, e.g. like this:

## [0.3.5] - 2022-10-13
[0.3.5]: https://github.com/atlassian/docker-infrastructure/compare/release-0.3.4...release-0.3.5

For consistancy reasons it could be helpful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #31

@mgrzaslewicz mgrzaslewicz merged commit 1a80684 into master Sep 12, 2023
6 checks passed
@mgrzaslewicz mgrzaslewicz deleted the jperf-836-changelog branch September 12, 2023 09:54

## [0.3.7] - 2023-09-11
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants